Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require helm v2.16.0 explicitly and minor CI updates #1911

Merged
merged 3 commits into from
Nov 14, 2020

Conversation

consideRatio
Copy link
Member

@consideRatio consideRatio commented Nov 14, 2020

I made use of a helm template function (list concat) made available in helm v2.16 but not helm v2.15, due to that we need to explicitly require helm v2.16+. I know this has caused a bug for one user at least who ran into this error when upgrading to 0.10.2. By specifying this explicitly, anyone upgrading will from now on at least get a hard failure directly about this.

Besides that, I also add some small changes to the CI, such as strict linting of helm and passing a commit message when chartpress pushes a new helm chart package commit to our git based helm-chart repo.

@consideRatio consideRatio changed the title pr/a few small updates Require helm v2.16.0 explicitly and minor CI updates Nov 14, 2020
@consideRatio consideRatio merged commit fd5995f into jupyterhub:master Nov 14, 2020
@michzimny
Copy link

@consideRatio, may I ask why the required kubeVersion from 1.11 to 1.14? Is it really needed for z2jh 0.10.x or it's a mistake?

Even for z2jh 0.10.6 the docs say the required k8s version is 1.11.

@consideRatio
Copy link
Member Author

@michzimny the key need to upgrade to a higher k8s version related to the user-scheduler pod. We run a kube-scheduler binary (k8s official binary), and it serves the function of scheduling the user pods to nodes in a way that packs them tight. This customly configured binary acting as a k8s pod scheduler would not be compatible with such a large range of k8s versions.

We had also stopped testing against k8s so old as k8s 1.11. I'm not sure if the docs is correct of not, but you can inspect the required version according to the Chart.yaml of the Helm chart. I've lost track of things in detail at this point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants